Update float32 dtype support to match scikit-image 0.19 behavior #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the channel_axis argument from scikit-image 0.19 * drop alpha argument from gray2rgb (deprecated) * remove deprecated grey2rgb and rgb2grey * label2rgb: bg_label default changed * ENH: new saturation argument to label2rgb
raise error in structure_similariy when input images are smaller than win_size
support integer block_size in block_reduce set block_size for block_reduce
Fixes euler angles for the 3D case and makes behavior otherwise consistent.
fix behavior of warp/rescale/resize/etc for integer and boolean input types
add random_state kwarg to unsupervised_wiener
grlee77
added
breaking
grlee77
added
the
skimage 0.19 update
jjacobelli
approved these changes
Jan 10, 2022
|
As discussed last week, I will close this and we will make all changes related to scikit-image 0.19 in one PR (#190) |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
This PR builds on top of #189 and introduces new deprecations as in scikit-image 0.19. closes #98 Specifically: `selem` -> `footprint` `grey` -> `gray` `iterations` -> `num_iter` `max_iter` -> `max_num_iter` `min_iter` -> `min_num_iter` Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Gigon Bae (https://github.com/gigony) - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham URL: #190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #188 and makes float32 and float16 handling consistent with scikit-image 0.19. (must functions support float32, float16 gets promoted to float32)
It is also related to #98.