-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add channel_axis as in scikit-image 0.19 #188
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the channel_axis argument from scikit-image 0.19 * drop alpha argument from gray2rgb (deprecated) * remove deprecated grey2rgb and rgb2grey * label2rgb: bg_label default changed * ENH: new saturation argument to label2rgb
raise error in structure_similariy when input images are smaller than win_size
grlee77
added
breaking
Introduces a breaking change
improvement
Improves an existing functionality
skimage 0.19 update
PRs related to updating the API to match scikit-image 0.19
labels
Dec 24, 2021
jjacobelli
approved these changes
Jan 10, 2022
ajschmidt8
requested changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #190 (review)
As discussed last week, I will close this and we will make all changes related to scikit-image 0.19 in one PR (#190) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Introduces a breaking change
improvement
Improves an existing functionality
skimage 0.19 update
PRs related to updating the API to match scikit-image 0.19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls changes from many scikit-image 0.19.0 PRs related to deprecating
multichannel
in favor ofchannel_axis
. A few other minor PRs related to deprecations and updates tocolor.label2rgb
are incorporated here as well:The changes are mostly non-breaking, although a couple of deprecated functions have been removed (
rgb2grey
,grey2rgb
) and a change in the default value oflabel2rgb
'sbg_label
argument. The deprecatedalpha
argument was removed from gray2rgb.This is related to #98, but several additional PRs will also be needed before closing the issue.
Implements:
scikit-image/scikit-image#5156
scikit-image/scikit-image#5228
scikit-image/scikit-image#5284
scikit-image/scikit-image#5285
scikit-image/scikit-image#5286
scikit-image/scikit-image#5287
scikit-image/scikit-image#5288
scikit-image/scikit-image#5289
scikit-image/scikit-image#5348
scikit-image/scikit-image#5395
scikit-image/scikit-image#5462
scikit-image/scikit-image#5463
scikit-image/scikit-image#5550
scikit-image/scikit-image#5584
scikit-image/scikit-image#6095