Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel_axis as in scikit-image 0.19 #188

Closed
wants to merge 14 commits into from

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Dec 24, 2021

This PR pulls changes from many scikit-image 0.19.0 PRs related to deprecating multichannel in favor of channel_axis. A few other minor PRs related to deprecations and updates to color.label2rgb are incorporated here as well:

The changes are mostly non-breaking, although a couple of deprecated functions have been removed (rgb2grey, grey2rgb) and a change in the default value of label2rgb's bg_label argument. The deprecated alpha argument was removed from gray2rgb.

This is related to #98, but several additional PRs will also be needed before closing the issue.

Implements:
scikit-image/scikit-image#5156
scikit-image/scikit-image#5228
scikit-image/scikit-image#5284
scikit-image/scikit-image#5285
scikit-image/scikit-image#5286
scikit-image/scikit-image#5287
scikit-image/scikit-image#5288
scikit-image/scikit-image#5289
scikit-image/scikit-image#5348
scikit-image/scikit-image#5395
scikit-image/scikit-image#5462
scikit-image/scikit-image#5463
scikit-image/scikit-image#5550
scikit-image/scikit-image#5584
scikit-image/scikit-image#6095

@grlee77 grlee77 added breaking Introduces a breaking change improvement Improves an existing functionality skimage 0.19 update PRs related to updating the API to match scikit-image 0.19 labels Dec 24, 2021
@grlee77 grlee77 requested review from a team as code owners December 24, 2021 03:16
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grlee77
Copy link
Contributor Author

grlee77 commented Jan 17, 2022

As discussed last week, I will close this and we will make all changes related to scikit-image 0.19 in one PR (#190)

@grlee77 grlee77 closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change improvement Improves an existing functionality skimage 0.19 update PRs related to updating the API to match scikit-image 0.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants