Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Deprecate unflatten_nested_columns #10952

Closed
PointKernel opened this issue May 24, 2022 · 0 comments · Fixed by #11421
Closed

[FEA] Deprecate unflatten_nested_columns #10952

PointKernel opened this issue May 24, 2022 · 0 comments · Fixed by #11421
Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.
Projects
v22.08 Release

Comments

@PointKernel
Copy link
Member

Is your feature request related to a problem? Please describe.
When working on #10770 , @ttnghia pointed out groupby::hash is the only use case of unflatten_nested_columns (see #10770 (comment)).

Describe the solution you'd like
We should remove this function once #10770 is merged.
@PointKernel PointKernel added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. tech debt labels May 24, 2022
@PointKernel PointKernel added this to Issue-Needs prioritizing in v22.08 Release via automation May 24, 2022
@PointKernel PointKernel mentioned this issue May 24, 2022
Merged
@PointKernel PointKernel added the good first issue Good for newcomers label May 24, 2022
@SrikarVanavasam SrikarVanavasam mentioned this issue Aug 1, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Aug 3, 2022
@SrikarVanavasam
Deprecate unflatten_nested_columns (#11421)
f31e5bd 
Closes #10952 

After #10770 was merged there are no more uses of `unflatten_nested_columns`. This pr removes `unflatten_nested_columns` and adjusts the tests accordingly.

Authors:
  - Srikar Vanavasam (https://github.com/SrikarVanavasam)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Karthikeyan (https://github.com/karthikeyann)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #11421
v22.08 Release automation moved this from Issue-Needs prioritizing to Done Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code.
Projects
No open projects
v22.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate unflatten_nested_columns SrikarVanavasam/cudf
1 participant
@PointKernel