Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add column constructor from device_uvector&&. #11115

Closed
bdice opened this issue Jun 15, 2022 · 1 comment · Fixed by #11356
Closed

[FEA] Add column constructor from device_uvector&&. #11115

bdice opened this issue Jun 15, 2022 · 1 comment · Fixed by #11356
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@bdice
Copy link
Contributor

bdice commented Jun 15, 2022

See: #11019 (comment)

We should add a column constructor to be constructible from a device_uvector&& so for outputs like this we can just more conveniently construct a device_uvector<size_type> and then construct the column when returning the output:

rmm::device_uvector<size_type> out_positions{...};
// ...
return make_unique<column>{std::move(out_positions)};

This is the "owning / move semantics" flavor of #10302 / #9621 / #9656. Like those issues/PRs, this is especially helpful when dealing with columns of indices.

@bdice bdice added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. labels Jun 15, 2022
@bdice bdice added this to Needs prioritizing in Feature Planning via automation Jun 15, 2022
@bdice bdice changed the title [FEA] Add column constructor from device_uvector&&. [FEA] Add column constructor from device_uvector&&. Jun 15, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@SrikarVanavasam SrikarVanavasam self-assigned this Jul 25, 2022
rapids-bot bot pushed a commit that referenced this issue Aug 3, 2022
Closes #11115 

This PR adds a `column` constructor to be constructible from a `device_uvector&&` using move semantics.

Authors:
  - Srikar Vanavasam (https://github.com/SrikarVanavasam)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)
  - Jake Hemstad (https://github.com/jrhemstad)

URL: #11356
Feature Planning automation moved this from Needs prioritizing to Closed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants