Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Converting from floating point types to fixed point types does not consider NaN and inf #15883

Closed
ttnghia opened this issue May 29, 2024 · 0 comments · Fixed by #15885
Closed

[BUG] Converting from floating point types to fixed point types does not consider NaN and inf #15883

ttnghia opened this issue May 29, 2024 · 0 comments · Fixed by #15885
Labels
bug Something isn't working

Comments

@ttnghia
Copy link
Contributor

ttnghia commented May 29, 2024

Currently, when converting floating point types to fixed point types, the special values NaN and inf are blindly scaled and cast to integer types, resulting in garbage values. The more reasonable outcome should be to nullify the output rows corresponding to these values in the input.
@ttnghia ttnghia added the bug Something isn't working label May 29, 2024
@ttnghia ttnghia mentioned this issue May 29, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 7, 2024
@ttnghia
Handling for NaN and inf when converting floating point to fixed …
39c5b86 
…point types (#15885)

This PR adds the ability to check for `NaN` and `inf` values when converting floating point types to fixed point types. For these input values, the corresponding output will be `null`.

Closes #15883.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Paul Mattione (https://github.com/pmattione-nvidia)
  - Shruti Shivakumar (https://github.com/shrshi)

URL: #15885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling for NaN and inf when converting floating point to fixed point types ttnghia/cudf
1 participant
@ttnghia