Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one_hot_encoding does not handle masked data properly #60

Closed
sklam opened this issue Aug 21, 2017 · 0 comments
Closed

one_hot_encoding does not handle masked data properly #60

sklam opened this issue Aug 21, 2017 · 0 comments

Comments

@sklam
Copy link
Contributor

sklam commented Aug 21, 2017

One-hot is not respecting the mask and is considering invalid locations. This will lead to incorrect result if the invalid location contains value that matches one of the category by accident.

Current workaround:

masked_series.fillna(something).one_hot_encoding()
seibert added a commit that referenced this issue Aug 23, 2017
@seibert
Merge pull request #63 from sklam/fix/masked_one_hot
f561e20 
Fix #60: one hot does not support column with null values
raydouglass pushed a commit that referenced this issue Nov 7, 2023
@shwina
Merge pull request #60 from rapidsai/wence/fix/index-again
de49d59 
Fix index `__new__` again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sklam