Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Implement set_names for cuDF.Index #6870

Closed
quasiben opened this issue Dec 1, 2020 · 0 comments · Fixed by #6929
Closed

[FEA] Implement set_names for cuDF.Index #6870

quasiben opened this issue Dec 1, 2020 · 0 comments · Fixed by #6929
Assignees
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@quasiben
Copy link
Member

quasiben commented Dec 1, 2020

Is your feature request related to a problem? Please describe.
In exploring a few xarray workflows I found I needed set_names on cudf.Index objects

Describe the solution you'd like
Pandas has a set_names function on Indexes. It would be great if this feature also existed for cuDF

In [29]: pd.Index(np.arange(10)).set_names("Foobar")
Out[29]: Int64Index([0, 1, 2, 3, 4, 5, 6, 7, 8, 9], dtype='int64', name='Foobar')

I would like the above to exist for cuD and CuPy

cudf.Index(cupy.arange(10)).set_names("Foobar")

Describe alternatives you've considered
No alternatives considered

@quasiben quasiben added feature request New feature or request Needs Triage Need team to review and classify labels Dec 1, 2020
@galipremsagar galipremsagar self-assigned this Dec 2, 2020
@galipremsagar galipremsagar added Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Dec 2, 2020
@galipremsagar galipremsagar linked a pull request Dec 6, 2020 that will close this issue
@rapids-bot rapids-bot bot closed this as completed in #6929 Dec 8, 2020
rapids-bot bot pushed a commit that referenced this issue Dec 8, 2020
Resolves: #6870 

This PR adds support for `set_names` API in both `Index` & `MultiIndex`.

Authors:
  - galipremsagar <sagarprem75@gmail.com>
  - GALI PREM SAGAR <sagarprem75@gmail.com>

Approvers:
  - Keith Kraus

URL: #6929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants