Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify custreamz and cudf_kafka recipes files #10065

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

jjacobelli
Copy link
Contributor

Adding build string constraints with Python version is not required for python-confluent-kafka dependency as the python version is fixed during conda build with --python flag

@jjacobelli jjacobelli added conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 18, 2022
@jjacobelli jjacobelli requested a review from a team as a code owner January 18, 2022 16:11
@jjacobelli jjacobelli self-assigned this Jan 18, 2022
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@jjacobelli
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #10065 (2938546) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 2938546 differs from pull request most recent head 2bbf85b. Consider uploading reports for the commit 2bbf85b to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10065      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20556     +251     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    18417     +242     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90a6fd...2bbf85b. Read the comment docs.

@ajschmidt8
Copy link
Member

rerun tests

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@galipremsagar
Copy link
Contributor

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor

rerun tests

@rapids-bot rapids-bot bot merged commit ab752d4 into rapidsai:branch-22.02 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants