Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with one_level_list schemas in parquet reader. #10750

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

nvdbaranec
Copy link
Contributor

Partially addresses: #10733

For a particular way of encoding list schemas (an old way that Spark seems to use sometimes), the parquet reader was accidentally propagating incorrect nesting information between columns. Just a simple bug of not popping an extra value off a stack.

Note: this is simply a fix so that the files read correctly, however the internal data in the file is actually of binary type and cudf converts these to string columns. This PR does not add support for binary as a real type in cudf.

…nformation to propagate between

columns, causing crashes.
@nvdbaranec nvdbaranec added bug Something isn't working 4 - Needs Review Waiting for reviewer to review or respond non-breaking Non-breaking change labels Apr 27, 2022
@nvdbaranec nvdbaranec requested review from a team as code owners April 27, 2022 21:07
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Apr 27, 2022
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining it to me, @nvdbaranec.

@mythrocks
Copy link
Contributor

I realize there isn't a good way to test the readers without checking in the parquet file itself. :/

@nvdbaranec
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #10750 (005949b) into branch-22.06 (d6e3068) will increase coverage by 0.06%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10750      +/-   ##
================================================
+ Coverage         86.36%   86.43%   +0.06%     
================================================
  Files               142      143       +1     
  Lines             22302    22444     +142     
================================================
+ Hits              19261    19399     +138     
- Misses             3041     3045       +4     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/io/parquet.py 92.39% <0.00%> (-1.40%) ⬇️
python/cudf/cudf/api/types.py 89.36% <0.00%> (-0.44%) ⬇️
python/cudf/cudf/core/dataframe.py 93.74% <0.00%> (-0.01%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <0.00%> (ø)
python/cudf/cudf/core/index.py 92.31% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 97.30% <0.00%> (ø)
python/cudf/cudf/_lib/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/testing/dataset_generator.py 73.25% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/_internals/expressions.py 92.85% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f3873...005949b. Read the comment docs.

@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants