Register cudf.core.groupby.Grouper objects to dask grouper_dispatch
#10982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h` (rapidsai#10838) This PR registers uses the (presumably shortly merged) dask `Grouper` dispatch to register `cudf.core.groupby.Grouper` objects to `cudf.DataFrame` objects. This should allow our own Grouper objects to be used in critical places in dask rather than pandas objects. This solution is favorable IMO rather than changing cuDF to handle pandas grouper objects directly. Xref dask/dask#9074 Authors: - https://github.com/brandon-b-miller Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: rapidsai#10838
brandon-b-miller
added
non-breaking
galipremsagar
approved these changes
May 26, 2022
galipremsagar
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10982 +/- ##
================================================
- Coverage 86.33% 86.31% -0.02%
================================================
Files 144 144
Lines 22681 22688 +7
================================================
+ Hits 19581 19584 +3
- Misses 3100 3104 +4
Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10838