Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev docs for documentation writing #11217

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 7, 2022

This PR adds a page describing how to write documentation for cuDF.

@vyasr vyasr added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Jul 7, 2022
@vyasr vyasr added this to PR-WIP in v22.08 Release via automation Jul 7, 2022
@vyasr vyasr self-assigned this Jul 7, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Jul 14, 2022

rerun tests

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@9b7a667). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c143ebb differs from pull request most recent head 5dc2982. Consider uploading reports for the commit 5dc2982 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #11217   +/-   ##
===============================================
  Coverage                ?   86.31%           
===============================================
  Files                   ?      144           
  Lines                   ?    22753           
  Branches                ?        0           
===============================================
  Hits                    ?    19640           
  Misses                  ?     3113           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7a667...5dc2982. Read the comment docs.

v22.08 Release automation moved this from PR-WIP to PR-Reviewer approved Jul 18, 2022
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments. Thanks, @vyasr!

@vyasr
Copy link
Contributor Author

vyasr commented Jul 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2f331b4 into rapidsai:branch-22.08 Jul 18, 2022
v22.08 Release automation moved this from PR-Reviewer approved to Done Jul 18, 2022
rapids-bot bot pushed a commit that referenced this pull request Aug 4, 2022
This PR adds a primary developer guide for Python. It provides a more complete and informative landing page for new developers. When #11217, #11199, and #11122 are merged, they will all be linked from this page to provide a complete set of developer documentation.

There is one main point of discussion that I would like reviewer comments on, and that is the section on directory and file organization. How do we want that aspect of cuDF to look?

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Lawrence Mitchell (https://github.com/wence-)
  - Ashwin Srinath (https://github.com/shwina)

URL: #11235
@vyasr vyasr deleted the docs/python_documentation branch January 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants