Add developer docs for writing tests #11199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
2 - In Progress
This was referenced Jul 9, 2022
shwina
reviewed
Jul 11, 2022
mroeschke
reviewed
Jul 12, 2022
Codecov ReportBase: 87.47% // Head: 86.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11199 +/- ##
================================================
- Coverage 87.47% 86.86% -0.61%
================================================
Files 133 135 +2
Lines 21826 21985 +159
================================================
+ Hits 19093 19098 +5
- Misses 2733 2887 +154
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
This PR adds a primary developer guide for Python. It provides a more complete and informative landing page for new developers. When #11217, #11199, and #11122 are merged, they will all be linked from this page to provide a complete set of developer documentation. There is one main point of discussion that I would like reviewer comments on, and that is the section on directory and file organization. How do we want that aspect of cuDF to look? Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Lawrence Mitchell (https://github.com/wence-) - Ashwin Srinath (https://github.com/shwina) URL: #11235
|
This PR has been labeled |
vyasr
added
3 - Ready for Review
bdice
reviewed
Oct 27, 2022
wence-
requested changes
Oct 31, 2022
bdice
approved these changes
Nov 1, 2022
mroeschke
approved these changes
Nov 1, 2022
|
rerun tests |
wence-
approved these changes
Nov 2, 2022
|
rerun tests |
shwina
reviewed
Nov 2, 2022
shwina
approved these changes
Nov 2, 2022
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation on how Python tests should be written.
Related to #4730. This PR will establish best practices. Follow-up PRs will be needed to implement them.
Resolves #6481.