[WIP] Implement dataframe.dropna() #1126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 6, 2019 10:12
kkraus14
added
2 - In Progress
kkraus14
reviewed
Mar 7, 2019
| def elem_and_or(a, b, operation) | ||
| assert a.size == b.size #Different length objects | ||
| out = rmm.device_array_like(a) | ||
| if operation == "and": |
There was a problem hiding this comment.
Need to add a check for if out.size > 0 here
kkraus14
reviewed
Mar 7, 2019
| assert a.size == b.size #Different length objects | ||
| out = rmm.device_array_like(a) | ||
| if operation == "and": | ||
| gpu_elem_and.forall(a.size)(a, b, out) |
There was a problem hiding this comment.
These should be on out.size for consistency
|
@kkraus14 @dillon-cullinan , whats the current status of the PR? |
3 tasks
|
I will be adding the libcudf functionality for multicolumn (DataFrame) drop_nulls() in 0.9 in #1744 . Should this PR move to 0.9 with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #911