-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return schema info from JSON reader #11419
Return schema info from JSON reader #11419
Conversation
…fea-json-reader-schema-info
…fea-json-reader-schema-info
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11419 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Python and C++ changes look fine to me.
return data_from_unique_ptr(move(c_out_table.tbl), | ||
column_names=column_names) | ||
meta_names = [name.decode() for name in c_result.metadata.column_names] | ||
df = cudf.DataFrame._from_data(*data_from_unique_ptr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you moved the _from_data
call into the Cython because update_struct_field_names
has to happen in Cython? In the long term I think that probably indicates some level of restructuring is required, but we can deal with that when we get around to cuIO/Cython refactoring more broadly.
@gpucibot merge |
Description
Populate the
schema_info
structure (in addition tocolumn_names
) to match the behavior of a (future) JSON reader that supports nested columns.Use the
schema_info
in Cython to set the struct columns' field names (unused until nested type support is added).Checklist