Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API for the future experimental JSON reader #11426

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Python API for the future experimental JSON reader #11426

merged 3 commits into from
Aug 3, 2022

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 2, 2022 •
edited
Loading

Description

Add Python API to expose the future experimental JSON reader implementation.
Add tests for C++ and Python experimental APIs.

Issue #8827

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added feature request New feature or request cuIO cuIO issue non-breaking Non-breaking change labels Aug 2, 2022
@vuule vuule self-assigned this Aug 2, 2022
@vuule vuule added this to PR-WIP in v22.10 Release via automation Aug 2, 2022
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@71a5292). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 46bfc53 differs from pull request most recent head 7e3e07c. Consider uploading reports for the commit 7e3e07c to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11426   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22856           
  Branches                ?        0           
===============================================
  Hits                    ?    19765           
  Misses                  ?     3091           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@elstehle elstehle added this to the Nested JSON reader milestone Aug 2, 2022
@vuule vuule marked this pull request as ready for review August 2, 2022 17:33
@vuule vuule requested review from a team as code owners August 2, 2022 17:33
@vuule
Copy link
Contributor Author

vuule commented Aug 3, 2022

rerun tests

ttnghia
ttnghia approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ approval.

karthikeyann
karthikeyann approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vuule vuule changed the base branch from branch-22.10 to branch-22.08 August 3, 2022 16:45
@vuule vuule changed the base branch from branch-22.08 to branch-22.10 August 3, 2022 16:45
@vuule
Copy link
Contributor Author

vuule commented Aug 3, 2022

@galipremsagar can you please review Python changes? They are mostly pulled from #11334, which you reviewed.

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 3, 2022
@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Aug 3, 2022
@vuule
Copy link
Contributor Author

vuule commented Aug 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b281fdf into rapidsai:branch-22.10 Aug 3, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 3, 2022
@vuule vuule deleted the fea-json_read-experimental-py-api branch August 10, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@ttnghia ttnghia ttnghia approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
No open projects
v22.10 Release
  
Done
Milestone
Nested JSON reader
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vuule @karthikeyann @ttnghia @galipremsagar @elstehle