Add groupby nunique aggregation benchmark
#11472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
ttnghia
added
3 - Ready for Review
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11472 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdice
approved these changes
Aug 4, 2022
Comment on lines
60
to
62
| requests.emplace_back(cudf::groupby::aggregation_request()); | ||
| requests[0].values = vals; | ||
| requests[0].aggregations.push_back(cudf::make_nunique_aggregation<cudf::groupby_aggregation>()); |
There was a problem hiding this comment.
It feels like we should initialize the aggregation request with the data, rather than create-and-modify the object.
There was a problem hiding this comment.
Unfortunately initializing the request class can't be done by initializer list because it has a unique_ptr member. We have to call emplace_back/push_back anyway :(
Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
3 tasks
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple benchmark for groupby
nuniqueaggregation.