copy_range ballot_syncs to have no execution dependency #11508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
3 - Ready for Review
davidwendt
approved these changes
Aug 10, 2022
davidwendt
reviewed
Aug 10, 2022
We can simplify the logic around determining the warp_mask by having both queries issued without a dependency
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
robertmaynard
force-pushed
the
copy_range_correct_ballot_warp
branch
from
44abb61
to
9da3419
Compare
ttnghia
approved these changes
Aug 10, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11508 +/- ##
===============================================
Coverage ? 86.48%
===============================================
Files ? 144
Lines ? 22850
Branches ? 0
===============================================
Hits ? 19761
Misses ? 3089
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can simplify the logic around determining the warp_mask by having both queries issued without a dependency
Checklist