Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework contains_scalar to check nulls at runtime #11622

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

davidwendt
Copy link
Contributor

Description

Rework the contains_scalar function to check nulls at runtime and reduce the amount of generated code.
The contains_scalar.cu compile time increased dramatically recently:
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/11743/Build_20Metrics_20Report/

The change here is expected to improve compile time significantly. The nvbench-mark showed no changes to performance.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 29, 2022
@davidwendt davidwendt added this to PR-WIP in v22.10 Release via automation Aug 29, 2022
@davidwendt davidwendt self-assigned this Aug 29, 2022
@davidwendt
Copy link
Contributor Author

Looks like compile time may be reduced from 27m to 12m
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/11762/Build_20Metrics_20Report/

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@a7b2e0c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11622   +/-   ##
===============================================
  Coverage                ?   86.41%           
===============================================
  Files                   ?      145           
  Lines                   ?    22993           
  Branches                ?        0           
===============================================
  Hits                    ?    19870           
  Misses                  ?     3123           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 30, 2022
@davidwendt davidwendt moved this from PR-WIP to PR-Needs review in v22.10 Release Aug 30, 2022
@davidwendt davidwendt marked this pull request as ready for review August 30, 2022 15:34
@davidwendt davidwendt requested a review from a team as a code owner August 30, 2022 15:34
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

v22.10 Release automation moved this from PR-Needs review to PR-Reviewer approved Aug 30, 2022
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0328e5d into rapidsai:branch-22.10 Aug 31, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Aug 31, 2022
@davidwendt davidwendt deleted the refactor-contains-scalar branch August 31, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants