-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework contains_scalar to check nulls at runtime #11622
Rework contains_scalar to check nulls at runtime #11622
Conversation
Looks like compile time may be reduced from 27m to 12m |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11622 +/- ##
===============================================
Coverage ? 86.41%
===============================================
Files ? 145
Lines ? 22993
Branches ? 0
===============================================
Hits ? 19870
Misses ? 3123
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
@gpucibot merge |
Description
Rework the
contains_scalar
function to check nulls at runtime and reduce the amount of generated code.The
contains_scalar.cu
compile time increased dramatically recently:https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/11743/Build_20Metrics_20Report/
The change here is expected to improve compile time significantly. The nvbench-mark showed no changes to performance.
Checklist