-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings in test_monotonic.py #12334
Fix warnings in test_monotonic.py #12334
Conversation
Codecov ReportBase: 88.37% // Head: 86.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12334 +/- ##
================================================
- Coverage 88.37% 86.04% -2.33%
================================================
Files 137 155 +18
Lines 22657 25421 +2764
================================================
+ Hits 20022 21873 +1851
- Misses 2635 3548 +913
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion, otherwise LGTM.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@gpucibot merge |
Description
One note with these deprecations. pandas has a special value used for parameters that are defaulted, and as a result explicitly passing None will throw a warning. We don't do this, hence the difference in the warnings contexts I use for our calls vs pandas (
pytest.warns
vsexpect_warning_if
). I didn't feel like this was worth commenting on in every place, but I can if reviewers want.Contributes to #9999 and #10363.
Checklist