Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in test_monotonic.py #12334

Merged
merged 3 commits into from
Dec 10, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 7, 2022

Description

One note with these deprecations. pandas has a special value used for parameters that are defaulted, and as a result explicitly passing None will throw a warning. We don't do this, hence the difference in the warnings contexts I use for our calls vs pandas (pytest.warns vs expect_warning_if). I didn't feel like this was worth commenting on in every place, but I can if reviewers want.

Contributes to #9999 and #10363.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 7, 2022
@vyasr vyasr requested a review from a team as a code owner December 7, 2022 18:36
@vyasr vyasr self-assigned this Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 88.37% // Head: 86.04% // Decreases project coverage by -2.32% ⚠️

Coverage data is based on head (8eede18) compared to base (a9f9958).
Patch coverage: 95.60% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02   #12334      +/-   ##
================================================
- Coverage         88.37%   86.04%   -2.33%     
================================================
  Files               137      155      +18     
  Lines             22657    25421    +2764     
================================================
+ Hits              20022    21873    +1851     
- Misses             2635     3548     +913     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 87.95% <ø> (-0.03%) ⬇️
python/cudf/cudf/core/dataframe.py 93.49% <66.66%> (-0.18%) ⬇️
python/cudf/cudf/core/_base_index.py 81.38% <100.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column_accessor.py 97.02% <100.00%> (+0.04%) ⬆️
python/cudf/cudf/core/index.py 94.10% <100.00%> (+1.17%) ⬆️
python/cudf/cudf/core/indexed_frame.py 92.44% <100.00%> (+0.30%) ⬆️
python/cudf/cudf/core/join/_join_helpers.py 98.52% <100.00%> (-0.07%) ⬇️
python/cudf/cudf/core/join/join.py 94.24% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/core/multiindex.py 92.23% <100.00%> (+0.05%) ⬆️
python/cudf/cudf/core/reshape.py 83.40% <100.00%> (+0.03%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, otherwise LGTM.

python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@vyasr
Copy link
Contributor Author

vyasr commented Dec 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d6582a1 into rapidsai:branch-23.02 Dec 10, 2022
@vyasr vyasr deleted the fix/monotonic_warnings branch January 23, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants