Refactor thrust_copy_if into cudf::detail::copy_if_safe

[ttnghia]

This extracts thrust_copy_if out of json_tree.cu and puts it into cudf/detail/utilities/algorithm.cuh with a new name cudf::detail::copy_if_safe. Such utility is useful not just for use in json_tree.cu but potentially in many other places. The next immediate use case will be to implement from_json in NVIDIA/spark-rapids-jni#844.

This also changes the work in #12079 to adopt the new function cudf::detail::copy_if_safe.

[codecov]

Codecov Report

Base: 86.58% // Head: 85.71% // Decreases project coverage by -0.86% ⚠️

Coverage data is based on head (cb836da) compared to base (b6dccb3).
Patch has no changes to coverable lines.

Additional details and impacted files

@@               Coverage Diff                @@
##           branch-23.02   #12455      +/-   ##
================================================
- Coverage         86.58%   85.71%   -0.87%     
================================================
  Files               155      155              
  Lines             24368    24798     +430     
================================================
+ Hits              21098    21255     +157     
- Misses             3270     3543     +273     

Impacted Files	Coverage Δ
python/cudf/cudf/_version.py	1.41% <0.00%> (-98.59%)	⬇️
python/cudf/cudf/core/buffer/spill_manager.py	72.50% <0.00%> (-7.50%)	⬇️
python/cudf/cudf/core/buffer/spillable_buffer.py	90.04% <0.00%> (-2.81%)	⬇️
python/cudf/cudf/utils/dtypes.py	77.77% <0.00%> (-1.69%)	⬇️
python/cudf/cudf/options.py	86.11% <0.00%> (-1.59%)	⬇️
python/cudf/cudf/core/single_column_frame.py	94.30% <0.00%> (-1.27%)	⬇️
...ython/custreamz/custreamz/tests/test_dataframes.py	98.38% <0.00%> (-1.01%)	⬇️
python/dask_cudf/dask_cudf/io/parquet.py	91.81% <0.00%> (-0.59%)	⬇️
python/cudf/cudf/core/multiindex.py	91.66% <0.00%> (-0.51%)	⬇️
python/cudf/cudf/core/algorithms.py	90.00% <0.00%> (-0.48%)	⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[PointKernel]

LGTM

Thanks!

[davidwendt]

There is already a function named cudf::detail::copy_if() defined in include/cudf/detail/copy_if.cuh

cudf/cpp/include/cudf/detail/copy_if.cuh

Line 323 in 8a1ff58

std::unique_ptr<table> copy_if(

Perhaps this function needs a different name?

[ttnghia]

I thought about that too but didn't have a very good candidate name. How about safe_copy_if?

[davidwendt]

I thought about that too but didn't have a very good candidate name. How about safe_copy_if?

We usually use safe as a suffix like the functions in here: https://github.com/rapidsai/cudf/blob/branch-23.02/cpp/include/cudf/detail/utilities/integer_utils.hpp
Perhaps copy_if_safe? That sounds more like "copy, if safe" instead of "copy-if, safe". Naming is hard.
I'm ok with either safe_copy_if or copy_if_safe.
Other options: blocked_copy_if or chunked_copy_if

[ttnghia]

We usually use safe as a suffix like the functions in here: https://github.com/rapidsai/cudf/blob/branch-23.02/cpp/include/cudf/detail/utilities/integer_utils.hpp Perhaps copy_if_safe? That sounds more like "copy, if safe" instead of "copy-if, safe". Naming is hard. I'm ok with either safe_copy_if or copy_if_safe. Other options: blocked_copy_if or chunked_copy_if

Then let's use copy_if_safe for consistency with other APIs having the _safe suffix.

[ttnghia]

@gpucibot merge