Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated regex functions from libcudf #13067

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Remove deprecated regex functions from libcudf #13067

merged 2 commits into from
Apr 10, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Apr 5, 2023 •
edited
Loading

Description

Removes the libcudf regex APIs that were deprecated in 23.04. All calls to these functions within the repo had already been removed.
Marking this breaking since APIs are being removed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 5, 2023
@davidwendt davidwendt self-assigned this Apr 5, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team strings strings issues (C++ and Python) and removed 2 - In Progress Currently a work in progress labels Apr 5, 2023
@davidwendt davidwendt marked this pull request as ready for review April 5, 2023 17:58
@davidwendt davidwendt requested a review from a team as a code owner April 5, 2023 17:58
@davidwendt davidwendt added breaking Breaking change 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 5, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ebe4757 into rapidsai:branch-23.06 Apr 10, 2023
@davidwendt davidwendt deleted the regex-remove-deprecated branch April 10, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidwendt @bdice @ttnghia