-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unnecessary uses of UNKNOWN_NULL_COUNT
#13102
Replace unnecessary uses of UNKNOWN_NULL_COUNT
#13102
Conversation
…e issue in parquet data
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
It'd be nice to know if we're eliminating many "real-world" calls to the |
I agree on both counts, that is an interesting question, and one that is hard to answer. A good starting point would be defining what really constitutes a real-world use case. Also, the changes in this PR come in two flavors: 1) precomputing a null count, in which case we're doing more work up front under the assumption that it will eventually be necessary, and 2) propagating a known null count, which is a strict reduction in work. The latter is more common in this PR and is the case where we'd hope for kernel reduction of course, but depending on the workflow being benchmarked that affected might be washed out by changes of the first type in instances where the null count is not actually used. Hard to say without asking a pretty precise question I suspect. |
/merge |
Description
This PR replaces uses of
cudf::UNKNOWN_NULL_COUNT
where the null count is either already known or trivially computed.Contributes to #11968
Checklist