STRING order-by column for RANGE window functions #13143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge calculations. This change is in preparation for supporting `STRING` order-by columns in range window functions. In the staging step for executing window range queries, the boundaries of each row's window are calculated. This involves subtracting/adding the `preceding`/`following` values from each order-by column row, and then searching backwards/forwards for the boundary values. The staging step has been using `column_device_view.data()` for accessing the order-by rows, an acceptable approach for when the order-by columns are numeric (e.g. `INT32`). This approach fails when the order-by column is a `STRING`, because `.data()` is not defined for such columns. A better approach would be to use `.element()` to directly access the rows, because it has special handling for `STRING`, among other types, while continuing to work for numeric primitives. In a followup to this change, support for `STRING` order-by columns will be added. Signed-off-by: MithunR <mythrocks@gmail.com>
1. Naming conventions for function/method parameter. 2. More const for identifiers, where applicable.
… into string-orderby-range-window
… into string-orderby-range-window
… into string-orderby-range-window
mythrocks
added
feature request
mythrocks
commented
Apr 17, 2023
davidwendt
approved these changes
Apr 18, 2023
ttnghia
reviewed
Apr 19, 2023
ttnghia
reviewed
Apr 19, 2023
ttnghia
reviewed
Apr 19, 2023
1. Renamed range_window_bounds::extent to extent_type. 2. Punctuation. 3. @brief.
ttnghia
approved these changes
Apr 19, 2023
|
/merge |
3 tasks
|
Thanks for the reviews, chaps. This is now merged. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Fixes unused parameter warning/error introduced by #13143 in `grouped_rolling.cu` ``` CMakeFiles/cudf.dir/src/rolling/grouped_rolling.cu.o /cudf/cpp/src/rolling/grouped_rolling.cu(280): error #177-D: parameter "delta" was declared but never referenced ``` This was found when building with nvcc 11.5. I was hoping there would be some clever partial specialization or function overloading that could be done here but none were as clean as the current implementation. Solution was to just add `[[maybe_unused]]` to offending parameter declaration. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #13192
mythrocks
added a commit
to NVIDIA/spark-rapids
that referenced
this pull request
Apr 27, 2023
Closes #7883. Depends on rapidsai/cudf#13143, rapidsai/cudf#13199. This commit adds support for `STRING` order-by columns for RANGE window functions. Before this commit, only numeric and timestamp types were supported as order-by columns in window specifications. However, it is possible to specify window frames such as follows: ```sql SELECT COUNT(1) OVER( PARTITION BY gid ORDER BY str_col ) ``` The implicit range here is `UNBOUNDED PRECEDING AND CURRENT ROW`, although explicit bounds may also be specified. Note that range values cannot be specified here, because `STRING` does not support intervals. This change should now allow the plugin to support `UNBOUNDED PRECEDING`, `UNBOUNDED FOLLOWING`, and `CURRENT ROW` as range window bounds, when the order-by column is `STRING`. Signed-off-by: MithunR <mythrocks@gmail.com>
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
This commit adds support for `FLOAT32` and `FLOAT64` order-by columns for RANGE-based window functions. ## Background Up until this commit, order-by columns for RANGE window functions were allowed to be integral numerics, timestamps, or strings (for unbounded/current rows). With this commit, window functions will be permitted to run on floating point value ranges. E.g. This supports windows defined with floating point deltas, like `rows with values exceeding the current row by no more than 3.14f`. This is in the same vein as the support for `DECIMAL` (#11645) and `STRING` (#13143). Authors: - MithunR (https://github.com/mythrocks) Approvers: - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: #13512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support to use
STRINGcolumns as the order-by column in range-based window functions.Context
A range-based window function allows a variable-width window to be defined around each row of an input column. The "range" describes the range of values in an order-by column.
Consider the following input:
agg_column = { 1, 1, 1, 1, 1, 1, 1 }; // The aggregation column. oby_column = { "0", "1", "2", "3", "4", "5", "6" }; // The order-by column. // ^If the range is defined as
[preceding=∞, following=0], then for the row at index2, the window would be rows0-2.The supported range bounds for
STRINGorder-by column are:UNBOUNDED(i.e. extending to the beginning/end of the column/group)CURRENT ROW, indicating that all equivalent values of the current row in theoby_column.Since
STRINGcolumns cannot have "delta" values, onlyUNBOUNDEDandCURRENT ROWbased window bounds are supported, unlike for numeric types which could specify a specific scalar delta value as a range.Depends on #13095.
Checklist