Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Change default dtype for get_dummies to bool #13174

Merged
merged 1 commit into from
Apr 22, 2023
Merged

[REVIEW] Change default dtype for get_dummies to bool #13174

merged 1 commit into from
Apr 22, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR changes the default dtype for get_dummies to bool from uint8 to match pandas-2.0: pandas-dev/pandas#48022

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team cuDF (Python) Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 19, 2023
@galipremsagar galipremsagar self-assigned this Apr 19, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner April 19, 2023 20:01
@galipremsagar galipremsagar requested review from charlesbluca and mroeschke and removed request for a team April 19, 2023 20:01
@galipremsagar galipremsagar mentioned this pull request Apr 19, 2023
Closed
@galipremsagar galipremsagar merged commit 27e18c8 into rapidsai:pandas_2.0_feature_branch Apr 22, 2023
17 of 19 checks passed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Apr 22, 2023
@galipremsagar galipremsagar mentioned this pull request May 16, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request May 17, 2023
@galipremsagar
Add warning for default dtype parameter in get_dummies (#13365)
85a4b38 
This PR adds a warning message for an upcoming change to the default `dtype` value in `get_dummies`: #13174

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #13365
@bdice bdice mentioned this pull request May 23, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request May 25, 2023
@bdice
Use <NA> instead of null to match pandas. (#13415)
03f0c0c 
This PR updates the behavior of one-hot encoding to use `<NA>` for null values rather than `null`. This aligns with pandas behavior.

This change is backported from #13174 since it applies to pandas 1.x as well as pandas 2.0.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ashwin Srinath (https://github.com/shwina)

URL: #13415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice Awaiting requested review from bdice

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@galipremsagar @mroeschke