Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for default dtype parameter in get_dummies #13365

Merged
merged 2 commits into from
May 17, 2023
Merged

Add warning for default dtype parameter in get_dummies #13365

merged 2 commits into from
May 17, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR adds a warning message for an upcoming change to the default dtype value in get_dummies: #13174

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels May 16, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner May 16, 2023 21:32
@galipremsagar galipremsagar self-assigned this May 16, 2023
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label May 16, 2023
@galipremsagar galipremsagar mentioned this pull request May 16, 2023
Closed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 17, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 85a4b38 into rapidsai:branch-23.06 May 17, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@galipremsagar @mroeschke