-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom nvbench entry point to ensure cudf::nvbench_base_fixture
usage
#13183
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-23.06
from
robertmaynard:bug/allow_use_custom_nvbench_entry_point
Apr 24, 2023
Merged
Use custom nvbench entry point to ensure cudf::nvbench_base_fixture
usage
#13183
rapids-bot
merged 5 commits into
rapidsai:branch-23.06
from
robertmaynard:bug/allow_use_custom_nvbench_entry_point
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that captures nvbench
This ensures that the `nvbench_base_fixture` we need, is constructed before any benchmark is run.
35f7ba8
to
4dc46a0
Compare
davidwendt
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
ttnghia
approved these changes
Apr 20, 2023
karthikeyann
approved these changes
Apr 20, 2023
bdice
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix, @robertmaynard. Looks good to me.
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
CMake
CMake build issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we used the
nvbench::main
CMake target which would cause the samemain.o
to re-used across targets.Since this object file was compiled without any knowledge of rmm or libcudf it wouldn't have our custom
NVBENCH_ENVIRONMENT
type. This caused our benchmarks to not execute with the rmm pool allocator.Checklist