-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor transform_lists_of_structs
in row_operators.cu
#13288
Refactor transform_lists_of_structs
in row_operators.cu
#13288
Conversation
transform_lists_of_structs
in row_operators.cu
transform_lists_of_structs
in row_operators.cu
transform_lists_of_structs
in row_operators.cu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requests -- overall this is great and the changes look much cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! The code looks in great shape now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big improvement here, thanks! Mostly small changes requested.
/merge |
This split the functions
transform_lists_of_structs
inrow_operators.cu
into separate functions or simplified their implementation. From one function that can process both cases of having either one or two input columns, now we have two functions, each one processes one case.Closes #13287.