Refactor transform_lists_of_structs in row_operators.cu
#13288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
ttnghia
changed the title
transform_lists_of_structs in row_operators.cu
ttnghia
changed the title
transform_lists_of_structs in row_operators.cutransform_lists_of_structs in row_operators.cu
ttnghia
requested review from
vyasr,
bdice and
divyegala
and removed request for
hyperbolic2346 and
nvdbaranec
bdice
requested changes
May 8, 2023
divyegala
approved these changes
May 8, 2023
vyasr
requested changes
May 11, 2023
vyasr
approved these changes
May 11, 2023
davidwendt
reviewed
May 12, 2023
hyperbolic2346
approved these changes
May 15, 2023
bdice
approved these changes
May 15, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This split the functions
transform_lists_of_structsinrow_operators.cuinto separate functions or simplified their implementation. From one function that can process both cases of having either one or two input columns, now we have two functions, each one processes one case.Closes #13287.