Add log messages about kvikIO compatibility mode #13363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
libcudf
ttnghia
reviewed
May 16, 2023
Comment on lines
+41
to
+42
| CUDF_LOG_INFO("Writing a file using kvikIO, with compatibility mode {}.", | ||
| _kvikio_file.is_compat_mode_on() ? "on" : "off"); |
There was a problem hiding this comment.
Should we also log for the else branch?
There was a problem hiding this comment.
No need to log anything in the else branch because it calls make_cufile_output, which includes the logging for that path (whether GDS was used or not).
Same goes for the other file, just with make_cufile_input.
ttnghia
reviewed
May 16, 2023
| @@ -42,6 +42,8 @@ class file_source : public datasource { | |||
| { | |||
| if (detail::cufile_integration::is_kvikio_enabled()) { | |||
| _kvikio_file = kvikio::FileHandle(filepath); | |||
| CUDF_LOG_INFO("Reading a file using kvikIO, with compatibility mode {}.", | |||
…fea-kvikio-compat-log
…into fea-kvikio-compat-log
ttnghia
approved these changes
May 22, 2023
hyperbolic2346
approved these changes
May 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log whether kvikIO's compatibility mode is on for a given file input/output.
Checklist