Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pylibcudf to developer guide #13639

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Add pylibcudf to developer guide #13639

merged 7 commits into from
Jul 12, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 29, 2023

Description

This PR defines the core design principles behind pylibcudf to guide ongoing work on the project.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Jun 29, 2023
@vyasr vyasr added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Jun 29, 2023
@vyasr vyasr mentioned this pull request Jun 29, 2023
Merged
3 tasks
wence-
wence- reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good high-level overview.

docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Show resolved Hide resolved
@vyasr vyasr requested a review from wence- July 11, 2023 01:04
wence-
wence- approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor fixes, but good to go! Thanks.

docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
docs/cudf/source/developer_guide/pylibcudf.md Outdated Show resolved Hide resolved
@vyasr @wence-
Apply suggestions from code review
82bc4bd 
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
@vyasr
Copy link
Contributor Author

vyasr commented Jul 11, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0f61fab into rapidsai:branch-23.08 Jul 12, 2023
53 checks passed
@GregoryKimball GregoryKimball mentioned this pull request Aug 19, 2023
Closed
@vyasr vyasr deleted the feat/pylibcudf_dev_guide branch January 23, 2024 21:21
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@shwina shwina shwina approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package
Projects
cuDF/Dask/Numba/UCX
Archived in project
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @wence- @shwina