Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pyorc dependency and use pandas/pyarrow instead #14323

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR removes dependency on pyorc in cudf altogether by using drop-in replacements found in pandas & pyarrow.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer 4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2023
@galipremsagar galipremsagar self-assigned this Oct 24, 2023
@galipremsagar galipremsagar requested review from a team as code owners October 24, 2023 19:34
@github-actions github-actions bot added the conda label Oct 24, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I have a few questions. Also be aware that #14321 tells us we should be cautious about importing pyarrow.orc except where it's necessary, since it will trigger S3 initialization.

python/cudf/cudf/tests/test_orc.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_orc.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_orc.py Outdated Show resolved Hide resolved
[
None,
None,
*(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above about unnecessary unpacking. Check for more instances of that in this file.

Copy link
Contributor Author

@galipremsagar galipremsagar Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need it here because it is a comprehension ...for _ in range(2))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that now.

@galipremsagar
Copy link
Contributor Author

Great. I have a few questions. Also be aware that #14321 tells us we should be cautious about importing pyarrow.orc except where it's necessary, since it will trigger S3 initialization.

Removed the imports where unnecessary 👍

Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!
LGTM, but I am a bit out of by Python depth here.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise the substitution LGTM. There are a few unnecessary extra changes, but they are cleanup so may as well merge them now that they're already done.

python/cudf/cudf/_fuzz_testing/orc.py Outdated Show resolved Hide resolved
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer 4 - Needs Review Waiting for reviewer to review or respond labels Oct 25, 2023
[
None,
None,
*(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that now.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 91aeec8 into rapidsai:branch-23.12 Oct 25, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants