Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cython libcpp wrappers #14382

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Remove Cython libcpp wrappers #14382

merged 6 commits into from
Nov 10, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 9, 2023 •
edited

Description

All of these wrappers have now been upstreamed into Cython as of Cython 3.0.3.

Contributes to #14023

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 9, 2023
@vyasr vyasr self-assigned this Nov 9, 2023
@vyasr vyasr requested review from a team as code owners November 9, 2023 02:06
@github-actions github-actions bot added the conda label Nov 9, 2023
@vyasr vyasr mentioned this pull request Nov 9, 2023
Closed
@vyasr
Copy link
Contributor Author

vyasr commented Nov 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 87d2a36 into rapidsai:branch-23.12 Nov 10, 2023
68 checks passed
@vyasr vyasr deleted the feat/remove_libcpp_wrappers branch November 10, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vyasr @bdice @galipremsagar @AyodeAwe