Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in public filling APIs for label_bins #14401

Merged
merged 19 commits into from
Jan 19, 2024
Merged

Expose streams in public filling APIs for label_bins #14401

merged 19 commits into from
Jan 19, 2024

Conversation

ZelboK
Copy link
Contributor

@ZelboK ZelboK commented Nov 14, 2023 •
edited
Loading

Description

Contributes to #925. Introduces cuda_stream parameter for downstream users to provide for labeling_bins

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ZelboK
Add test for stream validation for labeling bins. Introduce cuda_stre…
2b76d78 
…am parameter for label_bins constructor that can be used for downstream users
@ZelboK
fmt
995e881
@ZelboK ZelboK requested a review from a team as a code owner November 14, 2023 02:44
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 14, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 14, 2023
bdice
bdice reviewed Nov 15, 2023
View reviewed changes
cpp/include/cudf/labeling/label_bins.hpp Outdated Show resolved Hide resolved
cpp/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Nov 15, 2023

/ok to test

@ZelboK ZelboK requested review from a team as code owners November 23, 2023 02:03
@ZelboK ZelboK requested review from shwina and mroeschke and removed request for a team November 23, 2023 02:03
@github-actions github-actions bot added Python Affects Python cuDF API. conda Java Affects Java cuDF API. labels Nov 23, 2023
@ZelboK ZelboK changed the base branch from branch-23.12 to branch-24.02 November 23, 2023 02:03
@ZelboK @bdice
Update cpp/include/cudf/labeling/label_bins.hpp
878d73f 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@github-actions github-actions bot removed the Python Affects Python cuDF API. label Nov 23, 2023
bdice
bdice reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small style issues -- I'll attempt to push changes to correct them, then I'll trigger CI.

cpp/include/cudf/labeling/label_bins.hpp Outdated Show resolved Hide resolved
cpp/tests/streams/labeling_bins_test.cpp Outdated Show resolved Hide resolved
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 27, 2023
@bdice
Copy link
Contributor

bdice commented Nov 27, 2023

/ok to test

@bdice
Copy link
Contributor

bdice commented Nov 27, 2023

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Dec 19, 2023

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jan 11, 2024

@ZelboK can you fix the style here?

@ttnghia
Copy link
Contributor

ttnghia commented Jan 17, 2024

/ok to test

@bdice
Copy link
Contributor

bdice commented Jan 17, 2024

/ok to test

bdice
bdice approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@bdice
Copy link
Contributor

bdice commented Jan 18, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/ok to test

@rapids-bot rapids-bot bot merged commit 9bb9af6 into rapidsai:branch-24.02 Jan 19, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ZelboK ZelboK

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZelboK @vyasr @wence- @bdice @ttnghia