Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of volatile in Parquet #14448

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Remove the use of volatile in Parquet #14448

merged 2 commits into from
Nov 20, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Nov 17, 2023

Description

volatile should no be required in our code, unless there are compiler or synchronization issues.
This PR removes the use in Parquet reader and writer.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added cuIO cuIO issue Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2023
@vuule vuule self-assigned this Nov 17, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 17, 2023
@vuule vuule marked this pull request as ready for review November 20, 2023 22:49
@vuule vuule requested a review from a team as a code owner November 20, 2023 22:49
@vuule vuule changed the title Remove the use of volatile in Parquet Remove the use of volatile in Parquet Nov 20, 2023
@vuule
Copy link
Contributor Author

vuule commented Nov 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5831beb into rapidsai:branch-24.02 Nov 20, 2023
65 checks passed
@vuule vuule deleted the perf-parquet-no-volatile branch November 21, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vuule @ttnghia @davidwendt