Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of prefix increment overloads #14544

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix return type of prefix increment overloads #14544

merged 1 commit into from
Dec 6, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 1, 2023 •
edited
Loading

Description

Prefix increment operators should return a reference to the object. Some of our iterators don't return anything.
This PR fixes those iterators to be in line with what C++ expects.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2023
@vuule vuule self-assigned this Dec 1, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 1, 2023
@vuule vuule marked this pull request as ready for review December 4, 2023 19:50
@vuule vuule requested a review from a team as a code owner December 4, 2023 19:50
@vuule vuule requested review from bdice and shrshi December 4, 2023 19:50
@vuule
Copy link
Contributor Author

vuule commented Dec 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit 42b533f into rapidsai:branch-24.02 Dec 6, 2023
67 checks passed
@vuule vuule deleted the prefix-inc-return-type branch December 6, 2023 23:19
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@vuule @karthikeyann
Fix return type of prefix increment overloads (rapidsai#14544)
dec8fb0 
Prefix increment operators should return a reference to the object. Some of our iterators don't return anything.
This PR fixes those iterators to be in line with what C++ expects.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)

URL: rapidsai#14544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vuule @bdice @ttnghia