Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to deprecated factory function #14695

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix call to deprecated factory function #14695

merged 1 commit into from
Jan 4, 2024

Conversation

davidwendt
Copy link
Contributor

Description

A call to a deprecated cudf::make_strings_column factory function was introduced in #14664.
This call had been previously fixed in #14461 but was lost when the source file was moved in #14664.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 2, 2024
@davidwendt davidwendt self-assigned this Jan 2, 2024
@davidwendt davidwendt requested a review from a team as a code owner January 2, 2024 19:01
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4c01e95 into rapidsai:branch-24.02 Jan 4, 2024
67 checks passed
@davidwendt davidwendt deleted the fix-call-dep-factory branch January 4, 2024 00:40
@GregoryKimball GregoryKimball mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ttnghia ttnghia ttnghia approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidwendt @bdice @ttnghia