Ensure column.fillna signatures are consistent #14724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
approved these changes
Jan 9, 2024
bdice
reviewed
Jan 9, 2024
| method: Any = None, | ||
| dtype: Optional[Dtype] = None, | ||
| ) -> CategoricalColumn: | ||
| method: Optional[str] = None, |
There was a problem hiding this comment.
Just checking -- this is non-public so the API break of dropping dtype is not a "breaking change" right?
There was a problem hiding this comment.
I've been working under that assumption that cudf column objects are not public cc @shwina
There was a problem hiding this comment.
Yes, that should be fine! Just wanted to check in case this interacts with any future changes you were planning for public types.
There was a problem hiding this comment.
Gotcha. Yeah the arguments being modified in Column.fillna do not clash with Series/DataFrame.fillna
|
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns the definitions of
Columns.fillnaamong all subclasses.dtypelooks to only needed in certain instances to cast the fill value so can do that separately. Afill_nancan be avoided with its single usage in acan_castroutine by checking for nan firstChecklist