Rewrite cudf internals using pylibcudf groupby #14946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
vyasr
force-pushed
the
feat/use_pylibcudf_groupby
branch
from
3a98ceb
to
645d59a
Compare
shwina
reviewed
Feb 5, 2024
Comment on lines
+32
to
+36
| This class is functionally polymorphic and can represent either an | ||
| aggregation or a scan depending on the algorithm it is used with. For | ||
| details on the libcudf types it converts to, see | ||
| :cpp:class:`cudf::groupby::aggregation_request` and | ||
| :cpp:class:`cudf::groupby::scan_request`. |
There was a problem hiding this comment.
Is this maybe leaking too much implementation detail for a docstring?
There was a problem hiding this comment.
Hmm yeah it may be. In the interest of speed I'm going to merge this PR now, but I do think all of pylibcudf's documentation deserves a thorough review before we actually expose the API. I'll make a note that we should check on this docstring in particular when doing that.
shwina
reviewed
Feb 5, 2024
shwina
approved these changes
Feb 5, 2024
|
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #14945 to use pylibcudf's groupby in cudf's internals. It should not be merged until after that PR.
Checklist