Add distinct key inner join #14990
Merged
Add distinct key inner join #14990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
feature request
|
🔥🔥🔥 |
jlowe
reviewed
Feb 7, 2024
jlowe
reviewed
Feb 7, 2024
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
@jlowe The prototype should be ready for testing. Please let me know if you find any bugs/issues. I'm testing/tuning several alternative algorithms locally for the probe kernel so no need to worry about the performance for now.
|
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
wence-
approved these changes
Feb 17, 2024
ttnghia
reviewed
Feb 21, 2024
| @@ -21,6 +21,9 @@ | |||
|
|
|||
| namespace cudf::detail { | |||
|
|
|||
| /// Default load factor for cuco data structures | |||
| static double constexpr CUCO_DESIRED_LOAD_FACTOR = 0.5; | |||
ttnghia
reviewed
Feb 21, 2024
Comment on lines
+37
to
+41
| /** | ||
| * @brief An comparator adapter wrapping both self comparator and two table comparator | ||
| */ | ||
| template <typename Equal> | ||
| struct comparator_adapter { |
There was a problem hiding this comment.
Sound extremely familiar to me 😛 . Can you extract the code into some common header (or row_operators.cuh) instead of putting here? We would probably reuse it somewhere else.
There was a problem hiding this comment.
Such adapters look similar to each other while the contents are quite different, e.g. the insert comparator always returns false since we know all insert elements are distinct, the set key type is a pair of row hash value and row index which is rarely seen besides join operations, etc.
6 tasks
davidwendt
reviewed
Feb 21, 2024
ttnghia
approved these changes
Feb 22, 2024
ttnghia
reviewed
Feb 22, 2024
Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com>
|
/merge |
3 tasks
raydouglass
pushed a commit
that referenced
this pull request
Feb 28, 2024
Adds Java bindings to the distinct hash join functionality added in #14990. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Jim Brennan (https://github.com/jbrennan333) - Nghia Truong (https://github.com/ttnghia)
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Closes #15156 Fixes the invalid global read introduced by #14990 and simplifies the logic. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) URL: #15164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #14948
This PR adds a public
cudf::distinct_hash_joinclass that provides a fast code path for joins with distinct keys.Only distinct inner join is tackled in the current PR.
Checklist