Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create_chars_child_column utility #15241

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Removes the cudf::strings::detail::create_chars_child_column utility. This is not longer needed or used.
Removing it helps prevent inadvertently using it to wrap chars data with a cudf column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 6, 2024
@davidwendt davidwendt self-assigned this Mar 6, 2024
@davidwendt davidwendt marked this pull request as ready for review March 6, 2024 22:52
@davidwendt davidwendt requested a review from a team as a code owner March 6, 2024 22:52
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The branch seems to be out of date with the base branch which may be fast forwarded.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2ebfc80 into rapidsai:branch-24.04 Mar 8, 2024
73 checks passed
@davidwendt davidwendt deleted the remove-create-chars-child branch March 8, 2024 12:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants