Implement DataFrame|Series.squeeze #15244
Conversation
mroeschke
added
Python
| [RangeIndex(start=0, stop=4, step=1)] | ||
|
|
||
| """ | ||
| return [self.index] |
There was a problem hiding this comment.
Should this be in SingleColumnFrame rather than IndexedFrame? This method is overridden in DataFrame.axes. I am not sure of our conventions for inheritance here.
There was a problem hiding this comment.
Yeah I wasn't sure where to put this. I thought to put this here because squeeze needs axes (or another method to get "number of axes"). Thoughts @shwina?
There was a problem hiding this comment.
A SingleColumnFrame doesn't have an index, so you can't implement axes there I think, I would put it on IndexedFrame if you want to share between Series and DataFrame.
There was a problem hiding this comment.
A
SingleColumnFramedoesn't have an index
Oh. I apologize. This is probably fine as-is, then.
There was a problem hiding this comment.
Can you additionally apply this patch to remove the workaround we have in dask-cudf for lack of squeeze right now?
diff --git a/python/dask_cudf/dask_cudf/expr/_expr.py b/python/dask_cudf/dask_cudf/expr/_expr.py
index cbe7a71cb7..85fd44b610 100644
--- a/python/dask_cudf/dask_cudf/expr/_expr.py
+++ b/python/dask_cudf/dask_cudf/expr/_expr.py
@@ -25,21 +25,6 @@ CumulativeBlockwise._args = PatchCumulativeBlockwise._args
CumulativeBlockwise._kwargs = PatchCumulativeBlockwise._kwargs
-# This can be removed if squeeze support is added to cudf,
-# or if squeeze is removed from the dask-expr logic.
-# See: https://github.com/rapidsai/cudf/issues/15177
-def _takelast(a, skipna=True):
- if not len(a):
- return a
- if skipna:
- a = a.bfill()
- # Cannot use `squeeze` with cudf
- return a.tail(n=1).iloc[0]
-
-
-TakeLast.operation = staticmethod(_takelast)
-
-
# This patch accounts for differences between
# numpy and cupy behavior. It may make sense
# to move this logic upstream.| [RangeIndex(start=0, stop=4, step=1)] | ||
|
|
||
| """ | ||
| return [self.index] |
There was a problem hiding this comment.
A SingleColumnFrame doesn't have an index, so you can't implement axes there I think, I would put it on IndexedFrame if you want to share between Series and DataFrame.
Sure thing, 3c38f6b |
|
/merge |
Description
closes #15177
Also moved
axesfromSeriestoIndexedFrameas it is overwritten byDataFrameanyways. Happy to move back if there was a reason not to include it thereChecklist