Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a cuFile error when running CSV tests with memcheck #15293

Merged

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Mar 13, 2024

Description

Closes #14140

Added a no-op CUDA call before creating a kvikio::FileHandle to avoid the error in cuFileDriverOpen.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Mar 13, 2024
@vuule vuule self-assigned this Mar 13, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 13, 2024
@vuule vuule marked this pull request as ready for review March 13, 2024 23:30
@vuule vuule requested a review from a team as a code owner March 13, 2024 23:30
// Workaround for https://github.com/rapidsai/cudf/issues/14140, where cuFileDriverOpen errors
// out if no CUDA calls have been made before it. This is a no-op if the CUDA context is
// already initialized
cudaFree(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a cufile bug (or at least a documentation bug about the necessary preconditions for cuFileDriverOpen), tracked internally as bug 4562392.

@vuule
Copy link
Contributor Author

vuule commented Mar 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit f697b3e into rapidsai:branch-24.04 Mar 16, 2024
76 checks passed
@vuule vuule deleted the war-cufiledriveropen-memcheck branch March 16, 2024 00:36
rapids-bot bot pushed a commit that referenced this pull request Apr 1, 2024
Issue #14140

Follow-up on #15293

Moving the `cudaFree(0)` call to a function called both by file `datasource` and `data_sink`.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Yunsong Wang (https://github.com/PointKernel)
  - Nghia Truong (https://github.com/ttnghia)

URL: #15335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Memcheck error found in CSV_TEST CsvReaderNumericTypeTest/0.SingleColumn
4 participants