Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all tests for arm arch #15402

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Enable all tests for arm arch #15402

merged 3 commits into from
Apr 5, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 27, 2024 •
edited by jakirkham

Description

This PR enables running all pytests for arm64 jobs.

xref: rapidsai/build-planning#36

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Mar 27, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner March 27, 2024 11:48
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 27, 2024
@github-actions github-actions bot added the ci label Mar 27, 2024
@galipremsagar
Copy link
Contributor Author

cc: @bdice @vyasr

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 27, 2024
@galipremsagar
Copy link
Contributor Author

Similar PRs in other repos for tracking:

rapidsai/cuml#5824
rapidsai/rmm#1510
rapidsai/raft#2248
rapidsai/cuvs#63
rapidsai/cucim#717
https://github.com/rapidsai/cuopt/pull/1774
https://github.com/rapidsai/legate-cuml/pull/13
rapidsai/ucxx#217
rapidsai/cuspatial#1365

vyasr
vyasr requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for the moment, I left some suggestions on Slack. I can approve once we decide whether or not to move forward with them (since they affect all the other repos too it's easier to discuss in Slack).

bdice
bdice reviewed Apr 1, 2024
View reviewed changes
ci/test_python_common.sh Outdated Show resolved Hide resolved
@bdice bdice requested a review from vyasr April 5, 2024 17:39
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6319ab7 into rapidsai:branch-24.06 Apr 5, 2024
69 checks passed
@galipremsagar galipremsagar mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galipremsagar @vyasr @bdice @AyodeAwe