Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all tests for arm arch #1510

Merged
merged 2 commits into from Apr 2, 2024
Merged

Enable all tests for arm arch #1510

merged 2 commits into from Apr 2, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Mar 27, 2024 •
edited by jakirkham

Description

This PR enables running all pytests for arm64 jobs.

xref: rapidsai/build-planning#36

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 27, 2024
@galipremsagar galipremsagar self-assigned this Mar 27, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner March 27, 2024 16:49
@github-actions github-actions bot added the ci label Mar 27, 2024
@galipremsagar galipremsagar mentioned this pull request Mar 27, 2024
Merged
3 tasks
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit bd3f0d8 into rapidsai:branch-24.06 Apr 2, 2024
52 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@jakirkham
Copy link
Member

jakirkham commented Apr 2, 2024 •
edited

@galipremsagar should we also delete this file (if it is unused)?

rmm/ci/wheel_smoke_test.py

Lines 1 to 5 in c60bcb1

import rmm
if __name__ == "__main__":
buf = rmm.DeviceBuffer(size=100)
assert buf.size == 100

Edit: This is being handled in PR ( #1521 )

@galipremsagar galipremsagar mentioned this pull request Apr 5, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Apr 5, 2024
@galipremsagar
Remove a file not being used (#1521)
cdf20a6 
We removed using this file in : #1510, this pr deletes the file.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1521
@galipremsagar galipremsagar mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@jakirkham jakirkham jakirkham approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees

@galipremsagar galipremsagar

Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galipremsagar @jakirkham @harrism @AyodeAwe