Fix decoding of dictionary encoded FIXED_LEN_BYTE_ARRAY data in Parquet reader #15601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
requested review from
galipremsagar,
charlesbluca,
karthikeyann and
davidwendt
github-actions
bot
added
libcudf
|
Testing with python because cudf cannot currently dictionary encode FIXED_LEN_BYTE_ARRAY data. |
|
CC @vuule |
vuule
added
bug
|
/ok to test |
vuule
approved these changes
Apr 26, 2024
karthikeyann
approved these changes
May 6, 2024
|
/ok to test |
karthikeyann
reviewed
May 6, 2024
galipremsagar
approved these changes
May 7, 2024
|
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading Parquet files with dictionary encoded FIXED_LEN_BYTE_ARRAY data fails because the dictionary page is never parsed, leading to out-of-bounds memory accesses.
Checklist