More safely parse CUDA versions when subprocess output is contaminated #16067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
bdice
approved these changes
Jun 24, 2024
vyasr
approved these changes
Jun 24, 2024
|
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some user environments, calling a subprocess may produce output that confuses the version parsing machinery inside
_ptxcompiler. Since the affected functions are vendored from the realptxcompilerpackage for the purposes of using them with CUDA 12, this fix will only these situations for CUDA 12+.Closes #16016.