Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudf::merge public API now support passing a user stream #16124

Merged
merged 6 commits into from
Jul 2, 2024
Merged

cudf::merge public API now support passing a user stream #16124

merged 6 commits into from
Jul 2, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Expands the cudf::merge function to support a user stream

Found as part of #15982 when building benchmarks

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change labels Jun 28, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 28, 2024
@robertmaynard robertmaynard marked this pull request as ready for review June 28, 2024 16:36
@robertmaynard robertmaynard requested a review from a team as a code owner June 28, 2024 16:36
@robertmaynard robertmaynard force-pushed the fea/cudf_merge_public_api_stream_support branch from 513c59c to ec315d5 Compare June 28, 2024 16:43
@github-actions github-actions bot added the CMake CMake build issue label Jun 28, 2024
@mhaseeb123
Copy link
Member

I think the new STREAM_MERGE_TEST are failing.

mhaseeb123
mhaseeb123 requested changes Jun 29, 2024
View reviewed changes
cpp/tests/streams/merge_test.cpp Outdated Show resolved Hide resolved
cpp/tests/streams/merge_test.cpp Outdated Show resolved Hide resolved
cpp/tests/streams/merge_test.cpp Outdated Show resolved Hide resolved
cpp/tests/streams/merge_test.cpp Outdated Show resolved Hide resolved
robertmaynard and others added 2 commits July 1, 2024 08:37
@robertmaynard @mhaseeb123
Apply test corrections
45b14d3 
Co-authored-by: Muhammad Haseeb <14217455+mhaseeb123@users.noreply.github.com>
@robertmaynard
Correct issues found by CI
1cf3204
@robertmaynard robertmaynard force-pushed the fea/cudf_merge_public_api_stream_support branch from cf90752 to 1cf3204 Compare July 1, 2024 14:36
@robertmaynard robertmaynard force-pushed the fea/cudf_merge_public_api_stream_support branch 2 times, most recently from 94e4b30 to 5058e23 Compare July 1, 2024 17:21
mhaseeb123
mhaseeb123 reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort. Waiting for CI tests to pass. Looks good otherwise!

@robertmaynard robertmaynard force-pushed the fea/cudf_merge_public_api_stream_support branch 2 times, most recently from 861ee69 to f5a5118 Compare July 1, 2024 21:24
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f534e20 into rapidsai:branch-24.08 Jul 2, 2024
81 checks passed
@robertmaynard robertmaynard deleted the fea/cudf_merge_public_api_stream_support branch July 2, 2024 20:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@vuule vuule vuule approved these changes

Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @mhaseeb123 @vuule