Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert valid metadata is passed in to_arrow for list_view #16198

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Assert valid metadata is passed in to_arrow for list_view #16198

merged 2 commits into from
Jul 12, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 4, 2024

Description

When converting a list column to arrow with metadata, one must provide metadata information for both the offset and value columns, or none at all. This is not completely obvious (perhaps we only need the metadata for the inner value column), so explicitly assert this case.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Assert valid metadata is passed in to_arrow for list_view
0ed7334 
When converting a list column to arrow with metadata, one must provide
metadata information for both the offset and value columns, or none at
all. This is not completely obvious (perhaps we only need the metadata
for the inner value column), so explicitly assert this case.

- Closes rapidsai#16069
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 4, 2024
@wence- wence- requested a review from a team as a code owner July 4, 2024 14:07
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 4, 2024
@davidwendt davidwendt mentioned this pull request Jul 5, 2024
Merged
3 tasks
@wence- @davidwendt
Wording
fffeded 
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
@wence-
Copy link
Contributor Author

wence- commented Jul 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 30e3209 into rapidsai:branch-24.08 Jul 12, 2024
76 checks passed
@wence- wence- deleted the wence/fix/16069 branch July 12, 2024 13:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@davidwendt davidwendt davidwendt approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Segfault in pylibcudf to_arrow interop when passing nested list and metadata
3 participants
@wence- @mythrocks @davidwendt