Handler csv reader options in cudf-polars #16211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
wence-
added
non-breaking
jameslamb
approved these changes
Jul 8, 2024
mroeschke
reviewed
Jul 8, 2024
| # because polars will already have handled them. | ||
| path = Path(p) | ||
| with path.open() as f: | ||
| while f.readline() == "\n": |
There was a problem hiding this comment.
Is this something that read_csv should eventually implement?
There was a problem hiding this comment.
At some point (maybe soon?), cudf-polars is not going to use cudf.read_csv, but rather the libcudf layer directly, so we'll probably need to do this here anyway.
mroeschke
reviewed
Jul 8, 2024
| @@ -206,24 +208,104 @@ def __post_init__(self) -> None: | |||
| if self.file_options.n_rows is not None: | |||
| raise NotImplementedError("row limit in scan") | |||
| if self.typ not in ("csv", "parquet"): | |||
| raise NotImplementedError(f"Unhandled scan type: {self.typ}") | |||
| if self.cloud_options is not None and any( | |||
| self.cloud_options[k] is not None for k in ("aws", "azure", "gcp") | |||
There was a problem hiding this comment.
Confirming that these strings are guaranteed to be in the dict at this point? If this option isn't supported at all would it be worthwhile just to only accept None here?
There was a problem hiding this comment.
csv reader has non-None cloud_options but the values are None, so I can't punt for cloud_options is not None.
mroeschke
approved these changes
Jul 8, 2024
Convert internal PySeries to public Series in translation.
If one passes an empty list for the names, things should work.
Possibly some pieces are missing, but this is much closer to complete.
wence-
force-pushed
the
wence/fea/polars-csv-options
branch
from
a13836a
to
184979c
Compare
|
/merge |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were just relying on the default cudf read_csv options which doesn't do the right thing if the user has configured things.
Now that polars passes through the information to us, we can handle things properly, and raise for unsupported cases.
While here, update to new polars release and adapt tests to bug fixes that have been made upstream.
Checklist