Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cuco_noexcept.diff #16254

Merged
merged 3 commits into from
Jul 11, 2024
Merged

remove cuco_noexcept.diff #16254

merged 3 commits into from
Jul 11, 2024

Conversation

trxcllnt
Copy link
Contributor

Description

This PR removes the cuDF cuco_noexcept.diff patch since it no longer applies after rapidsai/rapids-cmake#628.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 11, 2024
@trxcllnt trxcllnt requested a review from a team as a code owner July 11, 2024 17:17
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 11, 2024
@robertmaynard
Copy link
Contributor

We need to drop cpp/cmake/thirdparty/patches/cuco_override.json as well

@trxcllnt
Copy link
Contributor Author

Thanks, done.

@trxcllnt trxcllnt force-pushed the fix/delete-cuco-noexcept-patch branch from e65ad74 to df02241 Compare July 11, 2024 17:52
@trxcllnt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit adee00a into rapidsai:branch-24.08 Jul 11, 2024
79 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @robertmaynard @bdice