Fix Numba deprecation warnings with Numba 0.49+ #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many "internal" parts of Numba were moved with the release of 0.49. The old module locations can still be imported with a shim for the 0.49 release, but its use results in the emission of NumbaDeprecationWarning messages. The shims will be removed in Numba 0.50. This PR avoids the deprecation warnings and enables import from the new module paths where available, so that cuDF can be used with Numba 0.48, 0.49, or (a future release of) 0.50. Once Numba 0.49 or above is a cuDF requirement, the `try .. except ImportError` blocks can be replaced with imports exclusively from the new locations.
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #5033 +/- ##
============================================
Coverage 88.50% 88.51%
============================================
Files 54 54
Lines 10264 10271 +7
============================================
+ Hits 9084 9091 +7
Misses 1180 1180
Continue to review full report at Codecov.
|
kkraus14
approved these changes
Apr 28, 2020
kkraus14
added
5 - Ready to Merge
|
Thanks @gmarkall! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many "internal" parts of Numba were moved with the release of 0.49. The old module locations can still be imported with a shim for the 0.49 release, but its use results in the emission of NumbaDeprecationWarning messages. The shims will be removed in Numba 0.50.
This PR avoids the deprecation warnings and enables import from the new module paths where available, so that cuDF can be used with Numba 0.48, 0.49, or (a future release of) 0.50.
Once Numba 0.49 or above is a cuDF requirement, the
try .. except ImportErrorblocks can be replaced with imports exclusively from the new locations.